Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint as a dependency #176

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Add golangci-lint as a dependency #176

merged 1 commit into from
Apr 9, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Apr 8, 2021 •
edited
Loading

  • Removed the need to manually specify the version in workflow and Makefile
  • Added golangci config

@lucacome lucacome requested a review from a team April 8, 2021 18:21
@lucacome lucacome self-assigned this Apr 8, 2021
@lucacome lucacome requested review from ciarams87, soneillf5 and pleshakov and removed request for a team April 8, 2021 18:21
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 8, 2021
@lucacome lucacome enabled auto-merge (squash) April 8, 2021 18:21
@lucacome lucacome merged commit 048f132 into master Apr 9, 2021
@lucacome lucacome deleted the deps/golangci-lint branch April 9, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soneillf5 soneillf5 soneillf5 approved these changes

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

Assignees

@lucacome lucacome

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @pleshakov @soneillf5